Repository navigation
Upgrade packages to Pyrefly R1545.3 (landing group 216) - #5319
Closed
samwgoldman wants to merge 1 commit into
Closed
samwgoldman wants to merge 1 commit into
samwgoldman wants to merge 1 commit into
Conversation
Summary: X-link: meta-pytorch/torchrec#5048 This Phabricator Diff was generated from Pyrefly type-checker output by the per-target upgrade tool. It was not generated by an AI coding system. It adds `# pyrefly: ignore[...]` comments for type errors reported by Pyrefly R1545.3 and moves the packages it suppresses errors in to that release in `tools/build_defs/fbcode_macros/build_defs/rollouts/pyrefly_checker_rollout.bzl`, so they switch type checkers in the commit that adds their suppressions. Other packages move when the upgrade changes the default checker. It does not change Python runtime behavior or application logic. Landing group: `pyre_landing_split:1163914179934454:3` (attempt 1, 5 batches, 70 files) Merged patch SHA-256: `03836d36d8834219f1f87e83ffd74283b66e13a723db66c6bb24f10bd2a47a35` Packages moved to R1545.3: 25 Rebased by hand onto master, where `recir/utils/compile.py` conflicted, keeping master's version of it, then re-checked the 641 labels whose packages check with R1545.3 on master: no new errors. #pyreupgrade Differential Revision: D131835429
samwgoldman
added a commit
to samwgoldman/torchrec
that referenced
this pull request
Nov 14, 2026
…#5048) Summary: X-link: meta/Ax#5319 Pull Request resolved: meta-pytorch#5048 This Phabricator Diff was generated from Pyrefly type-checker output by the per-target upgrade tool. It was not generated by an AI coding system. It adds `# pyrefly: ignore[...]` comments for type errors reported by Pyrefly R1545.3 and moves the packages it suppresses errors in to that release in `tools/build_defs/fbcode_macros/build_defs/rollouts/pyrefly_checker_rollout.bzl`, so they switch type checkers in the commit that adds their suppressions. Other packages move when the upgrade changes the default checker. It does not change Python runtime behavior or application logic. Landing group: `pyre_landing_split:1163914179934454:3` (attempt 1, 5 batches, 70 files) Merged patch SHA-256: `03836d36d8834219f1f87e83ffd74283b66e13a723db66c6bb24f10bd2a47a35` Packages moved to R1545.3: 25 Rebased by hand onto master, where `recir/utils/compile.py` conflicted, keeping master's version of it, then re-checked the 641 labels whose packages check with R1545.3 on master: no new errors. #pyreupgrade Differential Revision: D131835429
meta-codesync Bot
pushed a commit
to meta-pytorch/torchrec
that referenced
this pull request
Nov 14, 2026
Summary: Pull Request resolved: #5057 X-link: meta/Ax#5319 Pull Request resolved: #5048 This Phabricator Diff was generated from Pyrefly type-checker output by the per-target upgrade tool. It was not generated by an AI coding system. It adds `# pyrefly: ignore[...]` comments for type errors reported by Pyrefly R1545.3 and moves the packages it suppresses errors in to that release in `tools/build_defs/fbcode_macros/build_defs/rollouts/pyrefly_checker_rollout.bzl`, so they switch type checkers in the commit that adds their suppressions. Other packages move when the upgrade changes the default checker. It does not change Python runtime behavior or application logic. Landing group: `pyre_landing_split:1163914179934454:3` (attempt 1, 5 batches, 70 files) Merged patch SHA-256: `03836d36d8834219f1f87e83ffd74283b66e13a723db66c6bb24f10bd2a47a35` Packages moved to R1545.3: 25 Rebased by hand onto master, where `recir/utils/compile.py` conflicted, keeping master's version of it, then re-checked the 641 labels whose packages check with R1545.3 on master: no new errors. bypass-github-export-checks pyrefly upgrade #pyreupgrade Differential Revision: D131835429 fbshipit-source-id: 7c331ecfea8aa7785568acdc380eb4248fc00db5
|
This pull request has been merged in fd8a67a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta-pytorch/torchrec#5048
This Phabricator Diff was generated from Pyrefly type-checker output by the per-target upgrade tool. It was not generated by an AI coding system.
It adds
# pyrefly: ignore[...]comments for type errors reported by Pyrefly R1545.3 and moves the packages it suppresses errors in to that release intools/build_defs/fbcode_macros/build_defs/rollouts/pyrefly_checker_rollout.bzl, so they switch type checkers in the commit that adds their suppressions. Other packages move when the upgrade changes the default checker. It does not change Python runtime behavior or application logic.Landing group:
pyre_landing_split:1163914179934454:3(attempt 1, 5 batches, 70 files)Merged patch SHA-256:
03836d36d8834219f1f87e83ffd74283b66e13a723db66c6bb24f10bd2a47a35Packages moved to R1545.3: 25
Rebased by hand onto master, where
recir/utils/compile.pyconflicted, keeping master's version of it, then re-checked the 641 labels whose packages check with R1545.3 on master: no new errors.#pyreupgrade
Differential Revision: D131835429